Do not prompt for password to start owner API (#656)

* Do not prompt for password to start owner API

It makes no sense to ask for the password if one only wants to initialize the APIs. Asking for the password makes things unnecessarily difficult and insecure in case I, as a system administrator, want to have the APIs running as a system service.

* Update wallet_args.rs

* Update wallet_args.rs

opening wallet if password argument is present

* Update wallet_args.rs
This commit is contained in:
David Tavarez 2022-07-12 11:32:43 +02:00 committed by GitHub
parent 95bb4c477e
commit b45802aa6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1037,10 +1037,10 @@ where
("recover", _) => open_wallet = false, ("recover", _) => open_wallet = false,
("cli", _) => open_wallet = false, ("cli", _) => open_wallet = false,
("owner_api", _) => { ("owner_api", _) => {
// If wallet exists, open it. Otherwise, that's fine too. // If wallet exists and password is present then open it. Otherwise, that's fine too.
let mut wallet_lock = wallet.lock(); let mut wallet_lock = wallet.lock();
let lc = wallet_lock.lc_provider().unwrap(); let lc = wallet_lock.lc_provider().unwrap();
open_wallet = lc.wallet_exists(None)?; open_wallet = wallet_args.is_present("pass") && lc.wallet_exists(None)?;
} }
_ => {} _ => {}
} }