From b45802aa6b5cfc28fa4c4a50615c0a8724922e3f Mon Sep 17 00:00:00 2001 From: David Tavarez <337107+davidtavarez@users.noreply.github.com> Date: Tue, 12 Jul 2022 11:32:43 +0200 Subject: [PATCH] Do not prompt for password to start owner API (#656) * Do not prompt for password to start owner API It makes no sense to ask for the password if one only wants to initialize the APIs. Asking for the password makes things unnecessarily difficult and insecure in case I, as a system administrator, want to have the APIs running as a system service. * Update wallet_args.rs * Update wallet_args.rs opening wallet if password argument is present * Update wallet_args.rs --- src/cmd/wallet_args.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/wallet_args.rs b/src/cmd/wallet_args.rs index 97a468db..87fb5243 100644 --- a/src/cmd/wallet_args.rs +++ b/src/cmd/wallet_args.rs @@ -1037,10 +1037,10 @@ where ("recover", _) => open_wallet = false, ("cli", _) => open_wallet = false, ("owner_api", _) => { - // If wallet exists, open it. Otherwise, that's fine too. + // If wallet exists and password is present then open it. Otherwise, that's fine too. let mut wallet_lock = wallet.lock(); let lc = wallet_lock.lc_provider().unwrap(); - open_wallet = lc.wallet_exists(None)?; + open_wallet = wallet_args.is_present("pass") && lc.wallet_exists(None)?; } _ => {} }