wallet: slatepacks messages errors handling

Cargo.lock

@@ -2553,6 +2553,7 @@ dependencies = [
  "serde_derive",
  "serde_json",
  "sys-locale",
+ "thiserror",
  "tokio 1.37.0",
  "tokio-util 0.7.10",
  "toml 0.8.12",

Cargo.toml

@@ -38,6 +38,7 @@ egui_extras = { version = "0.27.2", features = ["image"] }
 rust-i18n = "2.1.0"
 
 ## other
+thiserror = "1.0.58"
 futures = "0.3"
 dirs = "5.0.1"
 sys-locale = "0.3.0"

locales/en.yml

@@ -67,14 +67,16 @@ wallets:
   txs: Transactions
   messages: Messages
   transport: Transport
-  input_slatepack_desc: 'Enter received message to create a response or finalize the transaction:'
+  input_slatepack_desc: 'Enter received Slatepack message to create a response or finalize the transaction:'
   send_slatepack_desc: 'Send message to the receiver to finalize the transaction:'
   parse_slatepack_err: 'An error occurred during handling of the message, check input data:'
+  pay_balance_error: 'Account balance is insufficient to pay %{amount} ツ and network fee.'
   parse_i1_slatepack_desc: 'To pay %{amount} ツ send message to the receiver:'
   parse_i2_slatepack_desc: 'Finalize transaction to receive %{amount} ツ'
   parse_s1_slatepack_desc: 'To receive %{amount} ツ send message to the sender:'
   parse_s2_slatepack_desc: 'Finalize transaction to send %{amount} ツ'
   response_slatepack_err: 'An error occurred during creation of the response, check input data:'
+  response_exists_err: 'Such transaction already exists:'
   create_request_desc: 'Create a request to send or receive the funds:'
   send_request_desc: 'You have created a request to send %{amount} ツ. Send message to the receiver of the funds:'
   send_slatepack_err: An error occurred during creation of request to send funds, check input data.

locales/ru.yml

@@ -67,14 +67,16 @@ wallets:
   txs: Транзакции
   messages: Сообщения
   transport: Транспорт
-  input_slatepack_desc: 'Введите полученное сообщение для создания ответа или завершения транзакции:'
+  input_slatepack_desc: 'Введите полученное Slatepack сообщение для создания ответа или завершения транзакции:'
   send_slatepack_desc: 'Отправьте сообщение получателю средств для завершения транзакции:'
   parse_slatepack_err: 'Во время обработки сообщения произошла ошибка, проверьте входные данные:'
+  pay_balance_error: 'Средств на аккаунте недостаточно для оплаты %{amount} ツ и комиссии сети.'
   parse_i1_slatepack_desc: 'Для оплаты %{amount} ツ отправьте сообщение получателю:'
   parse_i2_slatepack_desc: 'Завершите транзакцию для получения %{amount} ツ'
   parse_s1_slatepack_desc: 'Для получения %{amount} ツ отправьте сообщение отправителю:'
   parse_s2_slatepack_desc: 'Завершите транзакцию для отправки %{amount} ツ'
   response_slatepack_err: 'Во время создания ответа произошла ошибка, проверьте входные данные:'
+  response_exists_err: 'Такая транзакция уже существует:'
   create_request_desc: 'Cоздать запрос на получение или отправку средств:'
   send_request_desc: 'Вы создали запрос на отправку %{amount} ツ. Отправьте сообщение получателю средств:'
   send_slatepack_err: Во время создания запроса на отправку средств произошла ошибка, проверьте входные данные.

src/gui/views/wallets/wallet/messages.rs

@@ -16,6 +16,7 @@ use egui::{Id, Margin, RichText, ScrollArea};
 use egui::scroll_area::ScrollBarVisibility;
 use grin_core::core::{amount_from_hr_string, amount_to_hr_string};
 use grin_wallet_libwallet::{Slate, SlateState, TxLogEntry};
+use log::error;
 
 use crate::gui::Colors;
 use crate::gui::icons::{BROOM, CLIPBOARD_TEXT, COPY, DOWNLOAD, UPLOAD};
@@ -26,23 +27,42 @@ use crate::gui::views::wallets::wallet::types::{SLATEPACK_MESSAGE_HINT, WalletTa
 use crate::gui::views::wallets::wallet::WalletContent;
 use crate::wallet::Wallet;
 
+#[derive(Clone, Eq, PartialEq, Debug, thiserror::Error)]
+enum MessageError {
+    #[error("{0}")]
+    Response(String),
+    #[error("{0}")]
+    Parse(String),
+    #[error("{0}")]
+    Finalize(String),
+    #[error("{0}")]
+    Other(String),
+}
+
+impl MessageError {
+    pub fn text(&self) -> &String {
+        match self {
+            MessageError::Response(text) => text,
+            MessageError::Parse(text) => text,
+            MessageError::Finalize(text) => text,
+            MessageError::Other(text) => text
+        }
+    }
+}
+
 /// Slatepacks messages interaction tab content.
 pub struct WalletMessages {
-    /// Flag to check if send or receive request was opened.
+    /// Flag to check if send or invoice request was opened.
     send_request: bool,
 
     /// Slatepack message to create response message.
     message_edit: String,
     /// Parsed Slatepack message.
     message_slate: Option<Slate>,
-    /// Flag to check if there is an error happened on response creation.
+    /// Slatepack error on finalization, parse and response creation.
-    parse_error: bool,
+    message_error: Option<MessageError>,
     /// Generated Slatepack response message.
     response_edit: String,
-    /// Flag to check if there is an error happened on response creation.
-    response_error: bool,
-    /// Flag to check if there is an error happened on transaction finalization.
-    finalize_error: bool,
     /// Flag to check if Dandelion is needed to finalize transaction.
     use_dandelion: Option<bool>,
 
@@ -51,7 +71,7 @@ pub struct WalletMessages {
     /// Generated Slatepack message as request to send or receive funds.
     request_edit: String,
     /// Flag to check if there is an error happened on invoice creation.
-    request_error: bool,
+    request_error: Option<MessageError>,
 }
 
 /// Identifier for invoice amount [`Modal`].
@@ -63,14 +83,12 @@ impl Default for WalletMessages {
             send_request: false,
             message_edit: "".to_string(),
             message_slate: None,
-            parse_error: false,
+            message_error: None,
             response_edit: "".to_string(),
-            response_error: false,
-            finalize_error: false,
             use_dandelion: None,
             amount_edit: "".to_string(),
             request_edit: "".to_string(),
-            request_error: false,
+            request_error: None,
         }
     }
 }
@@ -169,18 +187,8 @@ impl WalletMessages {
                       cb: &dyn PlatformCallbacks) {
         // Setup description.
         let response_empty = self.response_edit.is_empty();
-        if self.parse_error {
+        if let Some(err) = &self.message_error {
-            ui.label(RichText::new(t!("wallets.parse_slatepack_err"))
+            ui.label(RichText::new(err.text()).size(16.0).color(Colors::RED));
-                .size(16.0)
-                .color(Colors::RED));
-        } else if self.response_error {
-            ui.label(RichText::new(t!("wallets.response_slatepack_err"))
-                .size(16.0)
-                .color(Colors::RED));
-        } else if self.finalize_error {
-            ui.label(RichText::new(t!("wallets.finalize_slatepack_err"))
-                .size(16.0)
-                .color(Colors::RED));
         } else {
             let desc_text = if response_empty && self.message_slate.is_none() {
                 t!("wallets.input_slatepack_desc")
@@ -194,16 +202,12 @@ impl WalletMessages {
                     SlateState::Standard2 => {
                         t!("wallets.parse_s2_slatepack_desc","amount" => amount)
                     }
-                    SlateState::Standard3 => {t!("wallets.input_slatepack_desc")}
                     SlateState::Invoice1 => {
-                        let a_f = u64::from(slate.fee_fields) + slate.amount;
+                        t!("wallets.parse_i1_slatepack_desc","amount" => amount)
-                        let a = amount_to_hr_string(a_f, true);
-                        t!("wallets.parse_i1_slatepack_desc","amount" => a)
                     }
                     SlateState::Invoice2 => {
                         t!("wallets.parse_i2_slatepack_desc","amount" => amount)
                     }
-                    SlateState::Invoice3 => {t!("wallets.input_slatepack_desc")}
                     _ => {
                         t!("wallets.input_slatepack_desc")
                     }
@@ -227,7 +231,12 @@ impl WalletMessages {
         ui.add_space(3.0);
         ScrollArea::vertical()
             .max_height(128.0)
-            .id_source(Id::from("receive_input").with(wallet.get_config().id))
+            .id_source(Id::from(
+                if response_empty {
+                    "message_input"
+                } else {
+                    "response_input"
+                }).with(wallet.get_config().id))
             .auto_shrink([false; 2])
             .show(ui, |ui| {
                 ui.add_space(7.0);
@@ -254,7 +263,7 @@ impl WalletMessages {
 
             ui.columns(columns_num, |columns| {
                 let first_column_content = |ui: &mut egui::Ui| {
-                    if self.message_slate.is_some() && !self.response_error && !self.parse_error {
+                    if self.message_slate.is_some() && self.message_error.is_none() {
                         self.clear_message_button_ui(ui);
                     } else {
                         let paste_text = format!("{} {}", CLIPBOARD_TEXT, t!("paste"));
@@ -268,7 +277,7 @@ impl WalletMessages {
                 } else {
                     columns[0].vertical_centered_justified(first_column_content);
                     columns[1].vertical_centered_justified(|ui| {
-                        if self.finalize_error || self.response_error || self.parse_error {
+                        if self.message_error.is_some() {
                             self.clear_message_button_ui(ui);
                         } else if !self.response_edit.is_empty() {
                             let copy_text = format!("{} {}", COPY, t!("copy"));
@@ -279,15 +288,15 @@ impl WalletMessages {
                             show_dandelion = true;
                             View::button(ui, t!("wallets.finalize"), Colors::GOLD, || {
                                 let message = self.message_edit.clone();
-                                match wallet.finalize(message, self.use_dandelion.unwrap()) {
+                                let use_dandelion = self.use_dandelion.unwrap();
-                                    Ok(_) => {
+                                if let Ok(_) = wallet.finalize(message, use_dandelion) {
                                     self.message_edit.clear();
                                     self.message_slate = None;
-                                    },
+
-                                    Err(e) => {
+                                } else {
-                                        println!("error {}", e);
+                                    self.message_error = Some(
-                                        self.finalize_error = true
+                                        MessageError::Finalize(t!("wallets.finalize_slatepack_err"))
-                                    }
+                                    );
                                 }
                             });
                         }
@@ -312,73 +321,97 @@ impl WalletMessages {
             });
         }
 
-        // Parse Slatepack message if input field was changed to setup response input.
         message = if response_empty {
             &mut self.message_edit
         } else {
             &mut self.response_edit
         };
+
+        // Parse Slatepack message if input field was changed, resetting message error.
         if &message_before != message {
-            if message.is_empty() {
+            self.message_error = None;
-                self.message_slate = None;
+            self.parse_message(wallet);
+        }
     }
 
-            self.response_error = false;
+    /// Parse message input into [`Slate`], making operations like receive or pay to confirm.
-            self.parse_error = false;
+    fn parse_message(&mut self, wallet: &mut Wallet) {
-            if !self.message_edit.is_empty() {
+        if self.message_edit.is_empty() {
-                match wallet.parse_slatepack(self.message_edit.clone()) {
+           return;
-                    Ok(mut slate) => {
+        }
-                        // Try to get amount from transaction by id.
+        if let Ok(mut slate) = wallet.parse_slatepack(self.message_edit.clone()) {
-                        if slate.amount == 0 {
+            println!("parse_message: {}", slate);
+            // Make operation based on incoming state status.
+            match slate.state {
+                SlateState::Standard1 => {
+                    if let Ok(resp) = wallet.receive(self.message_edit.clone()) {
+                        self.response_edit = resp;
+                    } else {
+                        // Check if tx with same slate id already exists.
+                        let mut exists_tx = false;
                         let _ = wallet.get_data().unwrap().txs.clone().iter().map(|tx| {
                             if tx.tx_slate_id == Some(slate.id) {
-                                    slate.amount = if tx.amount_debited > tx.amount_credited {
+                                exists_tx= true;
-                                        tx.amount_debited - tx.amount_credited
+                                self.message_error = Some(
-                                    } else {
+                                    MessageError::Response(t!("wallets.response_exists_err"))
-                                        tx.amount_credited - tx.amount_debited
+                                );
-                                    }
                             }
                             tx
                         }).collect::<Vec<&TxLogEntry>>();
+                        if exists_tx {
+                            return;
                         }
-                        println!("SLATE: {}", slate);
+
-                        self.message_slate = Some(slate.clone());
+                        // Set default response error message.
-                        match slate.state {
+                        self.message_error = Some(
-                            SlateState::Unknown => {}
+                            MessageError::Response(t!("wallets.response_slatepack_err"))
-                            SlateState::Standard1 => {
+                        );
-                                match wallet.receive(self.message_edit.clone()) {
-                                    Ok(resp) => {
-                                        self.response_edit = resp;
-                                    }
-                                    Err(_) => {
-                                        self.response_error = true;
                     }
                 }
-                            }
-                            SlateState::Standard2 => {}
-                            SlateState::Standard3 => {}
                 SlateState::Invoice1 => {
                     match wallet.pay(self.message_edit.clone()) {
                         Ok(resp) => {
                             self.response_edit = resp;
                         }
-                                    Err(_) => {
+                        Err(err) => {
-                                        self.response_error = true;
+                            match err {
+                                grin_wallet_libwallet::Error::NotEnoughFunds {..} => {
+                                    let amount = amount_to_hr_string(slate.amount, true);
+                                    let a_t = t!("wallets.pay_balance_error", "amount" => amount);
+                                    self.message_error = Some(MessageError::Other(a_t));
+                                }
+                                _ => {
+                                    self.message_error = Some(
+                                        MessageError::Response(t!("wallets.response_slatepack_err"))
+                                    );
                                 }
                             }
                         }
-                            SlateState::Invoice2 => {
+                    }
+                }
+                _ => {}
+            }
 
-                            }
+            // Try to get amount  from transaction by id.
-                            SlateState::Invoice3 => {}
+            if slate.amount == 0 {
+                let _ = wallet.get_data().unwrap().txs.clone().iter().map(|tx| {
+                    if tx.tx_slate_id == Some(slate.id) {
+                        if slate.amount == 0 {
+                            let amount = if tx.amount_debited > tx.amount_credited {
+                                tx.amount_debited - tx.amount_credited
+                            } else {
+                                tx.amount_credited - tx.amount_debited
+                            };
+                            slate.amount = amount;
                         }
                     }
-                    Err(_) => {
+                    tx
+                }).collect::<Vec<&TxLogEntry>>();
+            }
+            self.message_slate = Some(slate.clone());
+        } else {
             self.message_slate = None;
-                        self.parse_error = true;
+            self.message_error = Some(MessageError::Parse(t!("wallets.response_slatepack_err")));
-                    }
-                }
-            }
         }
     }
 
@@ -386,9 +419,7 @@ impl WalletMessages {
     fn clear_message_button_ui(&mut self, ui: &mut egui::Ui) {
         let clear_text = format!("{} {}", BROOM, t!("clear"));
         View::button(ui, clear_text, Colors::BUTTON, || {
-            self.response_error = false;
+            self.message_error = None;
-            self.parse_error = false;
-            self.finalize_error = false;
             self.message_edit.clear();
             self.response_edit.clear();
             self.message_slate = None;
@@ -415,7 +446,7 @@ impl WalletMessages {
                     // Setup modal values.
                     self.send_request = true;
                     self.amount_edit = "".to_string();
-                    self.request_error = false;
+                    self.request_error = None;
                     // Show send amount modal.
                     Modal::new(AMOUNT_MODAL)
                         .position(ModalPosition::CenterTop)
@@ -431,7 +462,7 @@ impl WalletMessages {
                     // Setup modal values.
                     self.send_request = false;
                     self.amount_edit = "".to_string();
-                    self.request_error = false;
+                    self.request_error = None;
                     // Show receive amount modal.
                     Modal::new(AMOUNT_MODAL)
                         .position(ModalPosition::CenterTop)
@@ -468,24 +499,38 @@ impl WalletMessages {
             // Draw invoice amount text edit.
             let amount_edit_id = Id::from(modal.id).with(wallet.get_config().id);
             let amount_edit_opts = TextEditOptions::new(amount_edit_id).h_center();
-            let mut amount_edit = self.amount_edit.clone();
+            let mut amount_edit_before = self.amount_edit.clone();
-            View::text_edit(ui, cb, &mut amount_edit, amount_edit_opts);
+            View::text_edit(ui, cb, &mut amount_edit_before, amount_edit_opts);
-            if amount_edit != self.amount_edit {
+
-                self.request_error = false;
+            // Check value if input was changed.
-                match amount_from_hr_string(amount_edit.as_str()) {
+            if amount_edit_before != self.amount_edit {
-                    Ok(_) => {
+                self.request_error = None;
-                        self.amount_edit = amount_edit;
+                match amount_from_hr_string(amount_edit_before.as_str()) {
+                    Ok(a) => {
+                        if a <= 0 {
+                            return;
+                        }
+                        // Do not input amount more than balance in sending.
+                        if self.send_request {
+                            let b = wallet.get_data().unwrap().info.amount_currently_spendable;
+                            if b < a {
+                                return;
+                            }
+                        }
+                        self.amount_edit = amount_edit_before;
                     }
                     Err(_) => {}
                 }
             }
 
             // Show invoice creation error.
-            if self.request_error {
+            if self.request_error.is_some() {
                 ui.add_space(12.0);
-                ui.label(RichText::new(t!("wallets.invoice_slatepack_err"))
+                ui.vertical_centered(|ui| {
+                    ui.label(RichText::new(self.request_error.clone().unwrap().text())
                         .size(17.0)
                         .color(Colors::RED));
+                });
             }
 
             // Show modal buttons.
@@ -498,33 +543,44 @@ impl WalletMessages {
                     columns[0].vertical_centered_justified(|ui| {
                         View::button(ui, t!("modal.cancel"), Colors::WHITE, || {
                             self.amount_edit = "".to_string();
-                            self.request_error = false;
+                            self.request_error = None;
                             modal.close();
                         });
                     });
                     columns[1].vertical_centered_justified(|ui| {
                         // Button to create Slatepack message for request.
                         View::button(ui, t!("continue"), Colors::WHITE, || {
-                            match amount_from_hr_string(self.amount_edit.as_str()) {
+                            if let Ok(a) = amount_from_hr_string(self.amount_edit.as_str()) {
-                                Ok(amount) => {
                                 let message = if self.send_request {
-                                        wallet.send(amount)
+                                    wallet.send(a)
                                 } else {
-                                        wallet.issue_invoice(amount)
+                                    wallet.issue_invoice(a)
                                 };
                                 match message {
                                     Ok(message) => {
                                         self.request_edit = message;
                                         cb.hide_keyboard();
                                     }
-                                        Err(_) => {
+                                    Err(err) => {
-                                            self.request_error = true;
+                                        match err {
+                                            grin_wallet_libwallet::Error::NotEnoughFunds { .. } => {
+                                                let m = t!(
+                                                    "wallets.pay_balance_error",
+                                                    "amount" => self.amount_edit
+                                                );
+                                                self.request_error = Some(MessageError::Other(m));
+                                            }
+                                            _ => {
+                                                let m = t!("wallets.invoice_slatepack_err");
+                                                self.request_error = Some(MessageError::Other(m));
                                             }
                                         }
                                     }
-                                Err(_) => {
-                                    self.request_error = true;
                                 }
+                            } else {
+                                self.request_error = Some(
+                                    MessageError::Other(t!("wallets.invoice_slatepack_err"))
+                                );
                             }
                         });
                     });

src/lib.rs

@@ -214,6 +214,6 @@ fn setup_i18n() {
         locale.as_str()
     };
     if _rust_i18n_available_locales().contains(&locale_str) {
-        rust_i18n::set_locale(DEFAULT_LOCALE);
+        rust_i18n::set_locale(locale_str);
     }
 }