mirror of
https://github.com/mimblewimble/grin.git
synced 2025-02-02 17:31:08 +03:00
ef4f426474
* Sort pool tx by fee over weight for mining. Fixes #1105 * Bucketing dependent transactions before weighing. Minor tx weight fixes. * Limit length of tx chain, cleanup and test fixes * Cleanup all mining references to a hardcoded tx count * Small test improvement, cleanup
492 lines
14 KiB
Rust
492 lines
14 KiB
Rust
// Copyright 2018 The Grin Developers
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! Selection of inputs for building transactions
|
|
|
|
use keychain::{Identifier, Keychain};
|
|
use libtx::{build, slate::Slate, tx_fee};
|
|
use libwallet::error::{Error, ErrorKind};
|
|
use libwallet::internal::{keys, sigcontext};
|
|
use libwallet::types::*;
|
|
|
|
use util::LOGGER;
|
|
|
|
/// Initialize a transaction on the sender side, returns a corresponding
|
|
/// libwallet transaction slate with the appropriate inputs selected,
|
|
/// and saves the private wallet identifiers of our selected outputs
|
|
/// into our transaction context
|
|
|
|
pub fn build_send_tx_slate<T: ?Sized, C, K>(
|
|
wallet: &mut T,
|
|
num_participants: usize,
|
|
amount: u64,
|
|
current_height: u64,
|
|
minimum_confirmations: u64,
|
|
lock_height: u64,
|
|
max_outputs: usize,
|
|
change_outputs: usize,
|
|
selection_strategy_is_use_all: bool,
|
|
) -> Result<
|
|
(
|
|
Slate,
|
|
sigcontext::Context,
|
|
impl FnOnce(&mut T) -> Result<(), Error>,
|
|
),
|
|
Error,
|
|
>
|
|
where
|
|
T: WalletBackend<C, K>,
|
|
C: WalletClient,
|
|
K: Keychain,
|
|
{
|
|
let (elems, inputs, change_amounts_derivations, amount, fee) = select_send_tx(
|
|
wallet,
|
|
amount,
|
|
current_height,
|
|
minimum_confirmations,
|
|
lock_height,
|
|
max_outputs,
|
|
change_outputs,
|
|
selection_strategy_is_use_all,
|
|
)?;
|
|
|
|
// Create public slate
|
|
let mut slate = Slate::blank(num_participants);
|
|
slate.amount = amount;
|
|
slate.height = current_height;
|
|
slate.lock_height = lock_height;
|
|
slate.fee = fee;
|
|
let slate_id = slate.id.clone();
|
|
|
|
let keychain = wallet.keychain().clone();
|
|
|
|
let blinding = slate.add_transaction_elements(&keychain, elems)?;
|
|
|
|
// Create our own private context
|
|
let mut context = sigcontext::Context::new(
|
|
wallet.keychain().secp(),
|
|
blinding.secret_key(&keychain.secp()).unwrap(),
|
|
);
|
|
|
|
// Store our private identifiers for each input
|
|
for input in inputs {
|
|
context.add_input(&input.key_id);
|
|
}
|
|
|
|
// Store change output(s)
|
|
for (_, derivation) in &change_amounts_derivations {
|
|
let change_id = keychain.derive_key_id(derivation.clone()).unwrap();
|
|
context.add_output(&change_id);
|
|
}
|
|
|
|
let lock_inputs = context.get_inputs().clone();
|
|
let _lock_outputs = context.get_outputs().clone();
|
|
|
|
let root_key_id = keychain.root_key_id();
|
|
|
|
// Return a closure to acquire wallet lock and lock the coins being spent
|
|
// so we avoid accidental double spend attempt.
|
|
let update_sender_wallet_fn = move |wallet: &mut T| {
|
|
let mut batch = wallet.batch()?;
|
|
let log_id = batch.next_tx_log_id(root_key_id.clone())?;
|
|
let mut t = TxLogEntry::new(TxLogEntryType::TxSent, log_id);
|
|
t.tx_slate_id = Some(slate_id);
|
|
t.fee = Some(fee);
|
|
let mut amount_debited = 0;
|
|
t.num_inputs = lock_inputs.len();
|
|
for id in lock_inputs {
|
|
let mut coin = batch.get(&id).unwrap();
|
|
coin.tx_log_entry = Some(log_id);
|
|
amount_debited = amount_debited + coin.value;
|
|
batch.lock_output(&mut coin)?;
|
|
}
|
|
|
|
t.amount_debited = amount_debited;
|
|
|
|
// write the output representing our change
|
|
for (change_amount, change_derivation) in &change_amounts_derivations {
|
|
let change_id = keychain.derive_key_id(change_derivation.clone()).unwrap();
|
|
t.num_outputs += 1;
|
|
t.amount_credited += change_amount;
|
|
batch.save(OutputData {
|
|
root_key_id: root_key_id.clone(),
|
|
key_id: change_id.clone(),
|
|
n_child: change_derivation.clone(),
|
|
value: change_amount.clone(),
|
|
status: OutputStatus::Unconfirmed,
|
|
height: current_height,
|
|
lock_height: 0,
|
|
is_coinbase: false,
|
|
tx_log_entry: Some(log_id),
|
|
})?;
|
|
}
|
|
batch.save_tx_log_entry(t)?;
|
|
batch.commit()?;
|
|
Ok(())
|
|
};
|
|
|
|
Ok((slate, context, update_sender_wallet_fn))
|
|
}
|
|
|
|
/// Creates a new output in the wallet for the recipient,
|
|
/// returning the key of the fresh output and a closure
|
|
/// that actually performs the addition of the output to the
|
|
/// wallet
|
|
pub fn build_recipient_output_with_slate<T: ?Sized, C, K>(
|
|
wallet: &mut T,
|
|
slate: &mut Slate,
|
|
) -> Result<
|
|
(
|
|
Identifier,
|
|
sigcontext::Context,
|
|
impl FnOnce(&mut T) -> Result<(), Error>,
|
|
),
|
|
Error,
|
|
>
|
|
where
|
|
T: WalletBackend<C, K>,
|
|
C: WalletClient,
|
|
K: Keychain,
|
|
{
|
|
// Create a potential output for this transaction
|
|
let (key_id, derivation) = keys::next_available_key(wallet).unwrap();
|
|
|
|
let keychain = wallet.keychain().clone();
|
|
let root_key_id = keychain.root_key_id();
|
|
let key_id_inner = key_id.clone();
|
|
let amount = slate.amount;
|
|
let height = slate.height;
|
|
|
|
let slate_id = slate.id.clone();
|
|
let blinding =
|
|
slate.add_transaction_elements(&keychain, vec![build::output(amount, key_id.clone())])?;
|
|
|
|
// Add blinding sum to our context
|
|
let mut context = sigcontext::Context::new(
|
|
keychain.secp(),
|
|
blinding
|
|
.secret_key(wallet.keychain().clone().secp())
|
|
.unwrap(),
|
|
);
|
|
|
|
context.add_output(&key_id);
|
|
|
|
// Create closure that adds the output to recipient's wallet
|
|
// (up to the caller to decide when to do)
|
|
let wallet_add_fn = move |wallet: &mut T| {
|
|
let mut batch = wallet.batch()?;
|
|
let log_id = batch.next_tx_log_id(root_key_id.clone())?;
|
|
let mut t = TxLogEntry::new(TxLogEntryType::TxReceived, log_id);
|
|
t.tx_slate_id = Some(slate_id);
|
|
t.amount_credited = amount;
|
|
t.num_outputs = 1;
|
|
batch.save(OutputData {
|
|
root_key_id: root_key_id,
|
|
key_id: key_id_inner,
|
|
n_child: derivation,
|
|
value: amount,
|
|
status: OutputStatus::Unconfirmed,
|
|
height: height,
|
|
lock_height: 0,
|
|
is_coinbase: false,
|
|
tx_log_entry: Some(log_id),
|
|
})?;
|
|
batch.save_tx_log_entry(t)?;
|
|
batch.commit()?;
|
|
Ok(())
|
|
};
|
|
Ok((key_id, context, wallet_add_fn))
|
|
}
|
|
|
|
/// Builds a transaction to send to someone from the HD seed associated with the
|
|
/// wallet and the amount to send. Handles reading through the wallet data file,
|
|
/// selecting outputs to spend and building the change.
|
|
pub fn select_send_tx<T: ?Sized, C, K>(
|
|
wallet: &mut T,
|
|
amount: u64,
|
|
current_height: u64,
|
|
minimum_confirmations: u64,
|
|
lock_height: u64,
|
|
max_outputs: usize,
|
|
change_outputs: usize,
|
|
selection_strategy_is_use_all: bool,
|
|
) -> Result<
|
|
(
|
|
Vec<Box<build::Append<K>>>,
|
|
Vec<OutputData>,
|
|
Vec<(u64, u32)>, // change amounts and derivations
|
|
u64, // amount
|
|
u64, // fee
|
|
),
|
|
Error,
|
|
>
|
|
where
|
|
T: WalletBackend<C, K>,
|
|
C: WalletClient,
|
|
K: Keychain,
|
|
{
|
|
// select some spendable coins from the wallet
|
|
let (max_outputs, coins) = select_coins(
|
|
wallet,
|
|
amount,
|
|
current_height,
|
|
minimum_confirmations,
|
|
max_outputs,
|
|
selection_strategy_is_use_all,
|
|
);
|
|
|
|
// sender is responsible for setting the fee on the partial tx
|
|
// recipient should double check the fee calculation and not blindly trust the
|
|
// sender
|
|
|
|
// TODO - Is it safe to spend without a change output? (1 input -> 1 output)
|
|
// TODO - Does this not potentially reveal the senders private key?
|
|
//
|
|
// First attempt to spend without change
|
|
let mut fee = tx_fee(coins.len(), 1, 1, None);
|
|
let mut total: u64 = coins.iter().map(|c| c.value).sum();
|
|
let mut amount_with_fee = amount + fee;
|
|
|
|
if total == 0 {
|
|
return Err(ErrorKind::NotEnoughFunds {
|
|
available: 0,
|
|
needed: amount_with_fee as u64,
|
|
})?;
|
|
}
|
|
|
|
// The amount with fee is more than the total values of our max outputs
|
|
if total < amount_with_fee && coins.len() == max_outputs {
|
|
return Err(ErrorKind::NotEnoughFunds {
|
|
available: total,
|
|
needed: amount_with_fee as u64,
|
|
})?;
|
|
}
|
|
|
|
let num_outputs = change_outputs + 1;
|
|
|
|
// We need to add a change address or amount with fee is more than total
|
|
if total != amount_with_fee {
|
|
fee = tx_fee(coins.len(), num_outputs, 1, None);
|
|
amount_with_fee = amount + fee;
|
|
|
|
// Here check if we have enough outputs for the amount including fee otherwise
|
|
// look for other outputs and check again
|
|
while total < amount_with_fee {
|
|
// End the loop if we have selected all the outputs and still not enough funds
|
|
if coins.len() == max_outputs {
|
|
return Err(ErrorKind::NotEnoughFunds {
|
|
available: total as u64,
|
|
needed: amount_with_fee as u64,
|
|
})?;
|
|
}
|
|
|
|
// select some spendable coins from the wallet
|
|
let (_, coins) = select_coins(
|
|
wallet,
|
|
amount_with_fee,
|
|
current_height,
|
|
minimum_confirmations,
|
|
max_outputs,
|
|
selection_strategy_is_use_all,
|
|
);
|
|
fee = tx_fee(coins.len(), num_outputs, 1, None);
|
|
total = coins.iter().map(|c| c.value).sum();
|
|
amount_with_fee = amount + fee;
|
|
}
|
|
}
|
|
|
|
// build transaction skeleton with inputs and change
|
|
let (mut parts, change_amounts_derivations) =
|
|
inputs_and_change(&coins, wallet, amount, fee, change_outputs)?;
|
|
|
|
// This is more proof of concept than anything but here we set lock_height
|
|
// on tx being sent (based on current chain height via api).
|
|
parts.push(build::with_lock_height(lock_height));
|
|
|
|
Ok((parts, coins, change_amounts_derivations, amount, fee))
|
|
}
|
|
|
|
/// Selects inputs and change for a transaction
|
|
pub fn inputs_and_change<T: ?Sized, C, K>(
|
|
coins: &Vec<OutputData>,
|
|
wallet: &mut T,
|
|
amount: u64,
|
|
fee: u64,
|
|
num_change_outputs: usize,
|
|
) -> Result<(Vec<Box<build::Append<K>>>, Vec<(u64, u32)>), Error>
|
|
where
|
|
T: WalletBackend<C, K>,
|
|
C: WalletClient,
|
|
K: Keychain,
|
|
{
|
|
let mut parts = vec![];
|
|
|
|
// calculate the total across all inputs, and how much is left
|
|
let total: u64 = coins.iter().map(|c| c.value).sum();
|
|
|
|
parts.push(build::with_fee(fee));
|
|
|
|
// if we are spending 10,000 coins to send 1,000 then our change will be 9,000
|
|
// if the fee is 80 then the recipient will receive 1000 and our change will be
|
|
// 8,920
|
|
let change = total - amount - fee;
|
|
|
|
// build inputs using the appropriate derived key_ids
|
|
for coin in coins {
|
|
let key_id = wallet.keychain().derive_key_id(coin.n_child)?;
|
|
if coin.is_coinbase {
|
|
parts.push(build::coinbase_input(coin.value, key_id));
|
|
} else {
|
|
parts.push(build::input(coin.value, key_id));
|
|
}
|
|
}
|
|
|
|
let mut change_amounts_derivations = vec![];
|
|
|
|
if change == 0 {
|
|
debug!(
|
|
LOGGER,
|
|
"No change (sending exactly amount + fee), no change outputs to build"
|
|
);
|
|
} else {
|
|
debug!(
|
|
LOGGER,
|
|
"Building change outputs: total change: {} ({} outputs)", change, num_change_outputs
|
|
);
|
|
|
|
let part_change = change / num_change_outputs as u64;
|
|
let remainder_change = change % part_change;
|
|
|
|
for x in 0..num_change_outputs {
|
|
// n-1 equal change_outputs and a final one accounting for any remainder
|
|
let change_amount = if x == (num_change_outputs - 1) {
|
|
part_change + remainder_change
|
|
} else {
|
|
part_change
|
|
};
|
|
|
|
let keychain = wallet.keychain().clone();
|
|
let root_key_id = keychain.root_key_id();
|
|
let change_derivation = wallet.next_child(root_key_id.clone()).unwrap();
|
|
let change_key = keychain.derive_key_id(change_derivation).unwrap();
|
|
|
|
change_amounts_derivations.push((change_amount, change_derivation));
|
|
parts.push(build::output(change_amount, change_key));
|
|
}
|
|
}
|
|
|
|
Ok((parts, change_amounts_derivations))
|
|
}
|
|
|
|
/// Select spendable coins from a wallet.
|
|
/// Default strategy is to spend the maximum number of outputs (up to
|
|
/// max_outputs). Alternative strategy is to spend smallest outputs first
|
|
/// but only as many as necessary. When we introduce additional strategies
|
|
/// we should pass something other than a bool in.
|
|
/// TODO: Possibly move this into another trait to be owned by a wallet?
|
|
|
|
pub fn select_coins<T: ?Sized, C, K>(
|
|
wallet: &mut T,
|
|
amount: u64,
|
|
current_height: u64,
|
|
minimum_confirmations: u64,
|
|
max_outputs: usize,
|
|
select_all: bool,
|
|
) -> (usize, Vec<OutputData>)
|
|
// max_outputs_available, Outputs
|
|
where
|
|
T: WalletBackend<C, K>,
|
|
C: WalletClient,
|
|
K: Keychain,
|
|
{
|
|
// first find all eligible outputs based on number of confirmations
|
|
let root_key_id = wallet.keychain().root_key_id();
|
|
let mut eligible = wallet
|
|
.iter()
|
|
.filter(|out| {
|
|
out.root_key_id == root_key_id
|
|
&& out.eligible_to_spend(current_height, minimum_confirmations)
|
|
})
|
|
.collect::<Vec<OutputData>>();
|
|
|
|
let max_available = eligible.len();
|
|
|
|
// sort eligible outputs by increasing value
|
|
eligible.sort_by_key(|out| out.value);
|
|
|
|
// use a sliding window to identify potential sets of possible outputs to spend
|
|
// Case of amount > total amount of max_outputs(500):
|
|
// The limit exists because by default, we always select as many inputs as
|
|
// possible in a transaction, to reduce both the Output set and the fees.
|
|
// But that only makes sense up to a point, hence the limit to avoid being too
|
|
// greedy. But if max_outputs(500) is actually not enough to cover the whole
|
|
// amount, the wallet should allow going over it to satisfy what the user
|
|
// wants to send. So the wallet considers max_outputs more of a soft limit.
|
|
if eligible.len() > max_outputs {
|
|
for window in eligible.windows(max_outputs) {
|
|
let windowed_eligibles = window.iter().cloned().collect::<Vec<_>>();
|
|
if let Some(outputs) = select_from(amount, select_all, windowed_eligibles) {
|
|
return (max_available, outputs);
|
|
}
|
|
}
|
|
// Not exist in any window of which total amount >= amount.
|
|
// Then take coins from the smallest one up to the total amount of selected
|
|
// coins = the amount.
|
|
if let Some(outputs) = select_from(amount, false, eligible.clone()) {
|
|
debug!(
|
|
LOGGER,
|
|
"Extending maximum number of outputs. {} outputs selected.",
|
|
outputs.len()
|
|
);
|
|
return (max_available, outputs);
|
|
}
|
|
} else {
|
|
if let Some(outputs) = select_from(amount, select_all, eligible.clone()) {
|
|
return (max_available, outputs);
|
|
}
|
|
}
|
|
|
|
// we failed to find a suitable set of outputs to spend,
|
|
// so return the largest amount we can so we can provide guidance on what is
|
|
// possible
|
|
eligible.reverse();
|
|
(
|
|
max_available,
|
|
eligible.iter().take(max_outputs).cloned().collect(),
|
|
)
|
|
}
|
|
|
|
fn select_from(amount: u64, select_all: bool, outputs: Vec<OutputData>) -> Option<Vec<OutputData>> {
|
|
let total = outputs.iter().fold(0, |acc, x| acc + x.value);
|
|
if total >= amount {
|
|
if select_all {
|
|
return Some(outputs.iter().cloned().collect());
|
|
} else {
|
|
let mut selected_amount = 0;
|
|
return Some(
|
|
outputs
|
|
.iter()
|
|
.take_while(|out| {
|
|
let res = selected_amount < amount;
|
|
selected_amount += out.value;
|
|
res
|
|
})
|
|
.cloned()
|
|
.collect(),
|
|
);
|
|
}
|
|
} else {
|
|
None
|
|
}
|
|
}
|