Commit graph

1505 commits

Author SHA1 Message Date
hashmap
53bce41981
Don't use process::exit in wallet cmd (#1913)
Unlike panic it doesn't call destructors (Drop) so all open transactions
are not closed. It's fine when LMDB file is open by the current process
only, but if another process keeps the same file open such transactions
will be considered alive until the second process exits. We usually have
one or more long-lived process (like `wallet listen`) which opens the
same wallet db as short-lived wallet commands. When a command fails it
calls process::exit and as result leaks a transaction.
This pr replaces such calls with an exit code return, which allows to call
all destructors before calling process::exit.
Fixes #1822
2018-11-04 21:26:46 +01:00
Gary Yu
f645937a2b replace cyan and yellow which not easy to read on white background (#1903)
* replace cyan and yellow which not easy to read on white background

* wallet output color scheme configuration for terminal dark/white background

* use true for dark_background_color_scheme to make the default behavior same as before
2018-11-03 09:42:41 +01:00
Jeff Barg
cc63fe4d32 refactor: refactored the API into related handler files (#1914) 2018-11-03 07:46:12 +01:00
eupn
40d727a01c fix: more readable timestamp format for logging (#1912)
* Use more readable timestamp format for logging

* Add logging level highlighting

* Change date and time format to YYYYMMDD from MM-DD
2018-11-02 15:13:12 +00:00
Antioch Peverell
d23dec73d0
PMMRable cleanup (#1910)
* cleanup pmmrable and len()
introduce FixedLength trait with a const LEN
make Hash impl FixedLength for consistency

* rustfmt

* store tests cleanup

* rustfmt

* whats going on with those comments and rustfmt?
2018-11-01 20:14:46 +00:00
hashmap
9cebbf24b8 Update TLS wallet doc (#1908)
Cover Stratum server changes
2018-11-01 10:37:48 -07:00
hashmap
b087325761 Don't die on malformed HTTPS request (#1907)
Fixes #1906
2018-11-01 23:03:32 +08:00
Yeastplume
9d0641c2b8
Wallet restore fix (#1904)
* wallet restore txlog + status fixes

* rustfmt
2018-11-01 11:36:29 +00:00
hashmap
368e1a461e
Tiny store crate cleanup (#1899) 2018-11-01 12:34:47 +01:00
Antioch Peverell
12be191ecd
validate root of header MMR when processing headers (during sync and full blocks) (#1836)
validate root of header MMR when processing headers (during sync and full blocks) (#1836)
2018-11-01 09:51:32 +00:00
Gary Yu
e8f4c47178 Avoid unnecessary panic of some wallet commands (#1893)
Replace wallet command panic with map_err or unwrap_or_else
2018-10-31 13:26:17 -07:00
Antioch Peverell
d51522a9cd Genesis is height 0 (not height 1) (#1896) 2018-10-31 13:24:21 -07:00
hashmap
b01fcd2f56 Remove unused unsafe declarations (#1901) 2018-10-31 13:19:28 -07:00
Ignotus Peverell
385b385456
Minor block.rs cleanup (#1889) 2018-10-31 13:18:59 -07:00
Antioch Peverell
3b5a39dd42
we have not used the rm_log for a while, getting rid of it (#1897) 2018-10-31 11:16:27 +00:00
Gary Yu
a8bf2eb126 avoid long display of TxLogEntryType (#1894) 2018-10-31 10:31:24 +00:00
Antioch Peverell
bc0128ab88
be careful resetting sync_head (#1885)
* be careful resetting sync_head
make sure we have the header corresponding to header_head
and that nothing is corrupted from an earlier shutdown

* add logging when resetting heads due to missing header
2018-10-31 10:29:23 +00:00
Gary Yu
5651fa7a8f add some log to help analysis root cause of #1880 (#1891) 2018-10-31 10:23:15 +00:00
Ignotus Peverell
a028748f11
Trivial wallet file operations logging improvement (#1888) 2018-10-30 16:12:30 -07:00
Gary Yu
641e7f51f0 Adjust the title format of wallet txs output (#1882) 2018-10-30 14:40:53 -07:00
Ignotus Peverell
0b22789865
Cleanup and minor fixes to core after transaction.rs review (#1854) 2018-10-30 14:09:56 -07:00
Ignotus Peverell
6f14f4c998
Cleanup and simplify sync (locator, body, etc.) (#1860)
* Cleanup syncer and sync header (locator)
* Simplify body sync
* Remove duplicate head in locator, add greater case in close_enough
* Various sync small fixes and tuning after testing
* More close_enough tests and related minor fixes
2018-10-30 14:09:24 -07:00
Antioch Peverell
d3b491674a Cleanup unused archive_mode param (#1886) 2018-10-30 11:36:28 -07:00
Quentin Le Sceller
c8afc800ff
Small correction in Node API (#1881) 2018-10-30 15:49:45 +01:00
Blade Doyle
2587ef5eb0 Add shares edge_bits to the stratum submit log messages (#1876) 2018-10-29 11:27:27 -07:00
Antioch Peverell
17f15b6dae
Adapter check compact archive (#1873)
* we do want to run compaction for archive nodes (from the adapter)

* rustfmt
2018-10-29 15:03:23 +00:00
Ignotus Peverell
46051ee174
improve minimum difficulty handling (#1791)
* rename MIN_DIFFICULTY to UNIT_DIFFICULTY; define Difficulty::unit, fix INITIAL_DIFFICULTY
* improve minimum difficulty handling
* replace all Difficulty::one by ::min
* revert secondary scaling default in HeaderInfo; rename scaling_difficulty; refactor difficulty_data_to_vector
2018-10-27 10:37:44 -07:00
eupn
0959bf376c Avoid stdout and panic logging when TUI is running (#1837) 2018-10-27 10:37:03 -07:00
Ignotus Peverell
038e21859a
fix: add missing API in list (#1847)
Closes #1653

* Replace query parameter values with placeholders
* fix: replace wrong query parameter
* Extent query explanation
* Add missing port parameter
2018-10-27 10:36:25 -07:00
hashmap
456cd0318a
Add missing port parameter
Co-Authored-By: haarts <harmaarts@gmail.com>
2018-10-27 10:06:01 +02:00
Ignotus Peverell
bb5392548f
Take 2 2018-10-26 16:28:15 -07:00
Gary Yu
6a788e8a9a
tui: adjust the table column width (#1848) 2018-10-27 07:12:54 +08:00
Ignotus Peverell
6f3ae4563a
Small test fix 2018-10-26 16:07:12 -07:00
Ignotus Peverell
1121a38bd5
Logger fix 2018-10-26 15:35:21 -07:00
eupn
495c9ded58 Use temporary file to save bitmaps (#1840) 2018-10-26 20:50:26 +02:00
eupn
ee5d6859fc Translate introduction to russian (#1846) 2018-10-26 20:46:20 +02:00
Harm Aarts
930ceccdba Extent query explaination 2018-10-26 17:18:06 +02:00
Harm Aarts
46c862297d fix: replace wrong query parameter 2018-10-26 17:09:07 +02:00
Harm Aarts
365814303d Replace query parameter values with placeholders 2018-10-26 17:07:46 +02:00
Harm Aarts
322552dde4 fix: add missing API in list
Closes #1653
2018-10-26 15:28:43 +02:00
Ignotus Peverell
c083312ad4
Improve crate descriptors to be more cargo-friendly (#1844)
* Update secp dependency to use crates.io version
* Add more details to various Cargo.toml
* Remove use of env variables that aren't reliably provided by cargo
2018-10-25 17:44:50 -07:00
Ignotus Peverell
a42d66efff
Merge branch 'master' into unitdiff 2018-10-25 14:20:41 -07:00
hashmap
b889069722 Make sure the entire buffer was written (#1842)
We may write just a part of the buffer and we don't check the result, so
write_all is probably what we need here
2018-10-25 10:46:31 -07:00
eupn
58e68a867e Remove unwrap() and add tx. pool error member to Error enum (#1839) 2018-10-25 16:00:39 +02:00
eupn
711fad6c24 Remove TODO for counting of bytes that was already done (#1838) 2018-10-25 15:57:53 +02:00
hashmap
ab7a59b1c2
Pool crate cleanup (#1835)
* Refactor retrieve_transaction
* Cleanup transaction_pool
2018-10-25 14:21:36 +02:00
Antioch Peverell
4050f7fccb
handle re-orgs in transaction_pool (#1829)
* use reorg_cache in transaction_pool to safely handle txs during a re-org

* rustfmt

* comments
2018-10-24 17:57:31 +01:00
eupn
3d74d7fe85 Fix path to log file in panic message (#1815) 2018-10-24 09:13:57 -07:00
Quentin Le Sceller
c343c65051
Remove fluff in SendTXArgs (#1825) 2018-10-24 12:10:40 +02:00
Yeastplume
029450a5ce
remove file wallet (#1824) 2018-10-24 11:03:50 +01:00