Core/grin
0
0
Fork 0
mirror of https://github.com/mimblewimble/grin.git synced 2025-02-01 17:01:09 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

skip hydrate if missing kernels, just request full block (#3090)

Browse source
This commit is contained in:
Antioch Peverell 2019-10-10 16:46:00 +01:00 committed by GitHub
parent 8f4a1cba67
commit da2e752991
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
servers/src/common/adapters.rs
View file

@ -189,15 +189,16 @@ impl p2p::ChainAdapter for NetToChainAdapter {
};
debug!(
"adapter: txs from tx pool - {}, (unknown kern_ids: {})",
"compact_block_received: txs from tx pool - {}, (unknown kern_ids: {})",
txs.len(),
missing_short_ids.len(),
);
// TODO - 3 scenarios here -
// 1) we hydrate a valid block (good to go)
// 2) we hydrate an invalid block (txs legit missing from our pool)
// 3) we hydrate an invalid block (peer sent us a "bad" compact block) - [TBD]
// If we have missing kernels then we know we cannot hydrate this compact block.
if missing_short_ids.len() > 0 {
self.request_block(&cb.header, peer_info, chain::Options::NONE);
return Ok(true);
}
let block = match core::Block::hydrate_from(cb.clone(), txs) {
Ok(block) => {