Core/grin
0
0
Fork 0
mirror of https://github.com/mimblewimble/grin.git synced 2025-01-21 11:31:08 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fund calculation inconsistent (#582) (#595)

Browse source
This commit is contained in:
Heung B Lee 2018-01-10 15:05:06 -08:00 committed by Ignotus Peverell
parent bc171a4423
commit ac5010e8f7
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
wallet/src/types.rs
View file

@ -544,6 +544,13 @@ impl WalletData {
eligible.sort_by_key(|out| out.value); eligible.sort_by_key(|out| out.value);
// use a sliding window to identify potential sets of possible outputs to spend // use a sliding window to identify potential sets of possible outputs to spend
// Case of amount > total amount of max_outputs(500):
// The limit exists because by default, we always select as many inputs as possible in a transaction,
// to reduce both the UTXO set and the fees.
// But that only makes sense up to a point, hence the limit to avoid being too greedy.
// But if max_outputs(500) is actually not enought to cover the whole amount,
// the wallet should allow going over it to satisfy what the user wants to send.
// So the wallet considers max_outputs more of a soft limit.
if eligible.len() > max_outputs { if eligible.len() > max_outputs {
for window in eligible.windows(max_outputs) { for window in eligible.windows(max_outputs) {
let eligible = window.iter().cloned().collect::<Vec<_>>(); let eligible = window.iter().cloned().collect::<Vec<_>>();
@ -551,6 +558,12 @@ impl WalletData {
return outputs; return outputs;
} }
} }
// Not exist in any window of which total amount >= amount.
// Then take coins from the smallest one up to the total amount of selected coins = the amount.
if let Some(outputs) = self.select_from(amount, false, eligible.clone()) {
debug!(LOGGER, "Extending maximum number of outputs. {} outputs selected.", outputs.len());
return outputs;
}
} else { } else {
if let Some(outputs) = self.select_from(amount, default_strategy, eligible.clone()) { if let Some(outputs) = self.select_from(amount, default_strategy, eligible.clone()) {
return outputs; return outputs;