Core/grin
0
0
Fork 0
mirror of https://github.com/mimblewimble/grin.git synced 2025-05-11 11:41:15 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: early reject late submited share to avoid wrong current_block_versions or get none ()

Browse source
This commit is contained in:
Gary Yu 2018-12-22 03:22:14 +08:00 • committed by Ignotus Peverell
parent bc7780354c
commit 84d2966663
1 changed files with 14 additions and 13 deletions

27
servers/src/mining/stratumserver.rs
View file

@ -439,6 +439,20 @@ impl StratumServer {
// Validate parameters
let params: SubmitParams = parse_params(params)?;
if params.height != self.current_block_versions.last().unwrap().header.height {
// Return error status
error!(
"(Server ID: {}) Share at height {}, edge_bits {}, nonce {}, job_id {} submitted too late",
self.id, params.height, params.edge_bits, params.nonce, params.job_id,
);
worker_stats.num_stale += 1;
let e = RpcError {
code: -32503,
message: "Solution submitted too late".to_string(),
};
return Err(serde_json::to_value(e).unwrap());
}
let share_difficulty: u64;
let mut share_is_block = false;
@ -477,19 +491,6 @@ impl StratumServer {
return Err(serde_json::to_value(e).unwrap());
}
if params.height != self.current_block_versions.last().unwrap().header.height {
// Return error status
error!(
"(Server ID: {}) Share at height {}, hash {}, edge_bits {}, nonce {}, job_id {} submitted too late",
self.id, params.height, b.hash(), params.edge_bits, params.nonce, params.job_id,
);
worker_stats.num_stale += 1;
let e = RpcError {
code: -32503,
message: "Solution submitted too late".to_string(),
};
return Err(serde_json::to_value(e).unwrap());
}
// Get share difficulty
share_difficulty = b.header.pow.to_difficulty(b.header.height).to_num();
// If the difficulty is too low its an error