From 4ad2ed48a38ae435f83ef97270398ef0c749051b Mon Sep 17 00:00:00 2001
From: John Tromp <john.tromp@gmail.com>
Date: Sun, 5 May 2019 11:51:46 +0200
Subject: [PATCH] add proofsize check in pow verify (#2805)

---
 core/src/pow/cuckaroo.rs | 5 +++++
 core/src/pow/cuckatoo.rs | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/core/src/pow/cuckaroo.rs b/core/src/pow/cuckaroo.rs
index 5289a66f1..fe0c1ebdc 100644
--- a/core/src/pow/cuckaroo.rs
+++ b/core/src/pow/cuckaroo.rs
@@ -27,6 +27,7 @@ use crate::pow::common::{CuckooParams, EdgeType};
 use crate::pow::error::{Error, ErrorKind};
 use crate::pow::siphash::siphash_block;
 use crate::pow::{PoWContext, Proof};
+use crate::global;
 
 /// Instantiate a new CuckarooContext as a PowContext. Note that this can't
 /// be moved in the PoWContext trait as this particular trait needs to be
@@ -68,6 +69,10 @@ where
 	}
 
 	fn verify(&self, proof: &Proof) -> Result<(), Error> {
+		if proof.proof_size() != global::proofsize() {
+			return Err(ErrorKind::Verification(
+				"wrong cycle length".to_owned(),))?;
+		}
 		let nonces = &proof.nonces;
 		let mut uvs = vec![0u64; 2 * proof.proof_size()];
 		let mut xor0: u64 = 0;
diff --git a/core/src/pow/cuckatoo.rs b/core/src/pow/cuckatoo.rs
index e5407b298..19a645fed 100644
--- a/core/src/pow/cuckatoo.rs
+++ b/core/src/pow/cuckatoo.rs
@@ -20,6 +20,7 @@ use croaring::Bitmap;
 use crate::pow::common::{CuckooParams, EdgeType, Link};
 use crate::pow::error::{Error, ErrorKind};
 use crate::pow::{PoWContext, Proof};
+use crate::global;
 use crate::util;
 
 struct Graph<T>
@@ -280,6 +281,10 @@ where
 	/// Verify that given edges are ascending and form a cycle in a header-generated
 	/// graph
 	pub fn verify_impl(&self, proof: &Proof) -> Result<(), Error> {
+                if proof.proof_size() != global::proofsize() {
+                        return Err(ErrorKind::Verification( 
+                                "wrong cycle length".to_owned(),))?;
+                }
 		let nonces = &proof.nonces;
 		let mut uvs = vec![0u64; 2 * proof.proof_size()];
 		let mut xor0: u64 = (self.params.proof_size as u64 / 2) & 1;