Fallback to building empty block to mine (if txpool is somehow in invalid state) (#2451)

* log loudly if we fail to prepare txs for mining

servers/src/mining/mine_block.rs

@@ -107,8 +107,21 @@ fn build_block(
 	// Note: do not keep the difficulty_iter in scope (it has an active batch).
 	let difficulty = consensus::next_difficulty(head.height + 1, chain.difficulty_iter());
 
-	// extract current transaction from the pool
-	let txs = tx_pool.read().prepare_mineable_transactions()?;
+	// Extract current "mineable" transactions from the pool.
+	// If this fails for *any* reason then fallback to an empty vec of txs.
+	// This will allow us to mine an "empty" block if the txpool is in an
+	// invalid (and unexpected) state.
+	let txs = match tx_pool.read().prepare_mineable_transactions() {
+		Ok(txs) => txs,
+		Err(e) => {
+			error!(
+				"build_block: Failed to prepare mineable txs from txpool: {:?}",
+				e
+			);
+			warn!("build_block: Falling back to mining empty block.");
+			vec![]
+		}
+	};
 
 	// build the coinbase and the block itself
 	let fees = txs.iter().map(|tx| tx.fee()).sum();
@@ -138,16 +151,13 @@ fn build_block(
 	);
 
 	// Now set txhashset roots and sizes on the header of the block being built.
-	let roots_result = chain.set_txhashset_roots(&mut b);
-
-	match roots_result {
+	match chain.set_txhashset_roots(&mut b) {
 		Ok(_) => Ok((b, block_fees)),
-
-		// If it's a duplicate commitment, it's likely trying to use
-		// a key that's already been derived but not in the wallet
-		// for some reason, allow caller to retry
 		Err(e) => {
 			match e.kind() {
+				// If this is a duplicate commitment then likely trying to use
+				// a key that hass already been derived but not in the wallet
+				// for some reason, allow caller to retry.
 				chain::ErrorKind::DuplicateCommitment(e) => Err(Error::Chain(
 					chain::ErrorKind::DuplicateCommitment(e).into(),
 				)),